Skip to content

DM-50619: Add get_status method to PanDAService class.#89

Merged
MichelleGower merged 1 commit into
mainfrom
tickets/DM-50619
May 27, 2025
Merged

DM-50619: Add get_status method to PanDAService class.#89
MichelleGower merged 1 commit into
mainfrom
tickets/DM-50619

Conversation

@MichelleGower
Copy link
Copy Markdown
Contributor

@MichelleGower MichelleGower commented May 22, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 98.47328% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.83%. Comparing base (74a5378) to head (bbde2b8).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/test_panda_service.py 98.05% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #89       +/-   ##
===========================================
+ Coverage   25.76%   35.83%   +10.06%     
===========================================
  Files           9       10        +1     
  Lines         815      946      +131     
  Branches      137      155       +18     
===========================================
+ Hits          210      339      +129     
- Misses        596      597        +1     
- Partials        9       10        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elif workflow_status in ["Suspended"]:
state = WmsStates.HELD
else:
state = WmsStates.RUNNING
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a workflow is running, i.e. some tasks have not finished, its status in iDDS is Transforming. The status is mapped to "RUNNING" correctly here in this "else" block.

@MichelleGower MichelleGower merged commit 17389a3 into main May 27, 2025
18 checks passed
@MichelleGower MichelleGower deleted the tickets/DM-50619 branch May 27, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants